优化异常日志记录

src/main/java/org/sss/presentation/noui/context/NoUiPresentation.java

@@ -14,6 +14,7 @@ import org.sss.presentation.noui.api.request.NoUiRequest;
 import org.sss.presentation.noui.api.response.ErrorCodes;
 import org.sss.presentation.noui.common.Constants;
 import org.sss.presentation.noui.util.NoUiUtils;
+import org.sss.presentation.noui.util.StringUtil;
 import org.sss.util.ContainerUtils;
 
 import java.io.File;
@@ -210,7 +211,7 @@ public class NoUiPresentation extends AbstractNullPresentation {
     }
 
     public boolean message(MessageType paramMessageType, String paramString, Object paramObject) {
-        if(paramObject instanceof ExitTransactionException){
+        if (paramObject instanceof ExitTransactionException) {
             throw ExitTransactionException.class.cast(paramObject);
         }
 
@@ -245,7 +246,7 @@ public class NoUiPresentation extends AbstractNullPresentation {
                 this.message_code = paramString;
             }
             /*
-			 * if (MessageType.ERROR.equals(paramMessageType)) {
+             * if (MessageType.ERROR.equals(paramMessageType)) {
 			 * log.error(StringUtils.isEmpty(paramString) ? str1 : str1 + "：" +
 			 * paramString); }
 			 */
@@ -362,7 +363,7 @@ public class NoUiPresentation extends AbstractNullPresentation {
 
         codetable.put(((IBaseObject) paramIAttributeValue).getUrl(), paramList);
         paramIAttributeValue.setAttribute("CODEVALUES", paramList);
-		/*
+        /*
 		 * if (((paramIAttributeValue instanceof IBaseObject)) &&
 		 * (!this.codeValuesList.contains(paramIAttributeValue))) { IBaseObject
 		 * baseObject = (IBaseObject) paramIAttributeValue;
@@ -476,8 +477,16 @@ public class NoUiPresentation extends AbstractNullPresentation {
     @SuppressWarnings("rawtypes")
     private final void setModified(IAttribute paramIAttribute, boolean paramBoolean) {
         paramIAttribute = handleProxyField(paramIAttribute);
-        modifyMap.put(((IBaseObject) paramIAttribute).getUrl(), paramIAttribute);
-
+        try {
+            IBaseObject object = (IBaseObject) paramIAttribute;
+            if (StringUtil.isEmpty(object.getUrl())) {
+                log.warn("The url property of the " + object + " is empty");
+            } else {
+                modifyMap.put(object.getUrl(), paramIAttribute);
+            }
+        } catch (Exception e) {
+            log.error("setModified save occure exception", e);
+        }
     }
 
     @Override

src/main/java/org/sss/presentation/noui/controller/AbstractCommonController.java

@@ -224,17 +224,17 @@ public abstract class AbstractCommonController {
         String aliasActionUrl = alias.getAliasActionUrl();
         String actionUrl = alias.getRel().get(aliasActionUrl);
         IBaseObject baseObject = context.getSession().getBaseObject(context.getRoot(), actionUrl);
-        if (null == baseObject){
+        if (null == baseObject) {
             throw new NoUiException("onClickUrl :" + actionUrl + " is not exsit");
         }
         return baseObject;
     }
 
     private void doHandleReturnDataForModuleList(Alias alias, String aliasKey, Map<String, Object> dataMap, IModuleList moduleList, List<Map> lst, NoUiRequest noUiRequest) {
-        if(aliasKey.endsWith("__data")){
+        if (aliasKey.endsWith("__data")) {
             //直接返回结果集
             dataMap.put(aliasKey, lst);
-        }else{
+        } else {
             //对该list封装一层，data属性表示实际结果集；pagination属性（分页请求下才有）表示分页信息
             Map<String, Object> item = new HashMap<>();
             //查询数据
@@ -247,8 +247,8 @@ public abstract class AbstractCommonController {
             pagination.put(Constants.PAGINATION_TOTAL, total);
             pagination.put(Constants.PAGINATION_INDEX, index);
             item.put(Constants.PAGINATION, pagination);*/
-                Map<String, Object> paginationInfo =AbstractCache.getPageInfo(moduleList);
-                if(paginationInfo!=null){
+                Map<String, Object> paginationInfo = AbstractCache.getPageInfo(moduleList);
+                if (paginationInfo != null) {
                     item.put(Constants.PAGINATION, paginationInfo);
                 }
             }
@@ -280,6 +280,10 @@ public abstract class AbstractCommonController {
         Map<String, Object> modifyMap = gui.getModifyMap();
         List<String> containsKeys = new ArrayList<String>();
         for (Map.Entry<String, Object> modifyEntry : modifyMap.entrySet()) {
+            if (modifyEntry.getKey() == null) {
+                log.error("modifymap中存在键为空的元素:" + modifyEntry + ",请求路径是:" + noUiRequest.getMappingUrl());
+                continue;
+            }
             for (Map.Entry<String, String> aliasEntry : alias.getRel().entrySet()) {
                 String aliasKey = aliasEntry.getKey();
                 String aliasPath = aliasEntry.getValue();
@@ -287,10 +291,7 @@ public abstract class AbstractCommonController {
                     log.error("错误的mapping：" + noUiRequest.getMappingUrl() + "--" + aliasKey + "--" + aliasPath);
                     continue;
                 }
-                if (modifyEntry.getKey() == null) {
-                    log.error("modifymap中存在键为空的元素：" + noUiRequest.getMappingUrl());
-                    continue;
-                }
+
                 if (aliasPath.startsWith(modifyEntry.getKey())) {
                     int modifyKeyLen = modifyEntry.getKey().length();
                     if (!(aliasPath.length() == modifyKeyLen || aliasPath.charAt(modifyKeyLen) == '\\')) {